RR(S): JDK-8022616 u4 should not be used as a type for thread_id

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Tue Sep 24 11:53:38 PDT 2013


This looks good module Staffan comment on guarantee.

How do you test it?
Also, should it be tested on Mac OS as well?


Thanks,
Serguei

On 9/24/13 12:57 AM, Dmitry Samersoff wrote:
> Please review changes:
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
>
> Story:
>
> Tracing framework expect u4 as an id of thread
>
> pthread_t chosen as a tread id for variety of BSD platforms couldn't be
> converted to u4 so it cause compilation failure on BSD x64
>
> Solution:
>
> Change thread_id to pid_t and get this id  directly from kernel, the
> same manner as Linux code does. Mac Os X still uses mach_port instead of
> thread id.
>
> Tested on FreeBSD and OpenBSD and also code passed jprt.
>
> -Dmitry
>



More information about the hotspot-runtime-dev mailing list