FW: RFR (S): 8024492 [TESTBUG] Test library class Platform.java needs to include methds for missing OS's and architectures

[Christian Tornqvist]

Thanks for the reviews, I'm going to go ahead and push these changes without
the AIX, arm64 and ppc64 methods since I have no way of getting this
information. This can be addressed later when there's a need for it.

Thanks,
Christian

-----Original Message-----
From: Zhengyu Gu [mailto:zhengyu.gu at oracle.com] 
Sent: Tuesday, September 24, 2013 4:54 PM
To: Christian Tornqvist; Hotspot dev runtime
Subject: Re: FW: RFR (S): 8024492 [TESTBUG] Test library class Platform.java
needs to include methds for missing OS's and architectures

Look good to me.

-Zhengyu

On 9/19/2013 12:38 AM, David Holmes wrote:

> On 18/09/2013 7:00 AM, Christian Tornqvist wrote:
>> Hi David,
>>
>> Do you know what the os.arch values are for ppc64 and arm64 and 
>> os.name for AIX?
> For aix/ppc64 AFAICS in
>
> http://hg.openjdk.java.net/ppc-aix-port/stage/file/584dc2e95e04/common
> /autoconf/platform.m4
>
>
> it looks like ppc64 and aix. But I'm cc'ing Goetz to confirm that.
>
> For arm64 I would expect arm64 but I don't know how to confirm that.
>
> David
>
>> Thanks,
>> Christian
>>
>> -----Original Message-----
>> From: David Holmes [mailto:david.holmes at oracle.com]
>> Sent: Wednesday, September 11, 2013 11:15 PM
>> To: Christian Tornqvist
>> Cc:hotspot-runtime-dev at openjdk.java.net
>> Subject: Re: RFR (S): 8024492 [TESTBUG] Test library class 
>> Platform.java needs to include methds for missing OS's and 
>> architectures
>>
>> You might as well add ppc64, arm64 and AIX while you are there. At 
>> least then we won't have to update this again for quite a while.
>>
>> David.
>>
>> On 12/09/2013 5:25 AM, Christian Tornqvist wrote:
>>> Hi,
>>>
>>>
>>> This is a small change to add is<arch>() methods in the Platform 
>>> class for our supported platforms. I've checked the os.arch value on 
>>> all of them and made the change based on that.
>>>
>>> Webrev:
>>>
>>> http://cr.openjdk.java.net/~ctornqvi/webrev/8024492/webrev.00/
>>>
>>> Bug:
>>>
>>> http://bugs.sun.com/view_bug.do?bug_id=8024492
>>>
>>> Thanks,
>>>
>>> Christian
>>>