RFR: 8038473 Remove support for old T1 libthread
Daniel D. Daugherty
daniel.daugherty at oracle.com
Tue Apr 1 20:46:19 UTC 2014
On 4/1/14 3:04 AM, Frederic Parain wrote:
> Hi David,
>
> Thank you for the review, the indentation is now fixed:
>
> http://cr.openjdk.java.net/~fparain/8038473/webrev.01/
Thumbs up!
src/os/aix/vm/os_aix.cpp
No comments.
src/os/bsd/vm/os_bsd.cpp
No comments.
src/os/linux/vm/os_linux.cpp
No comments.
src/os/solaris/vm/osThread_solaris.cpp
No comments.
src/os/solaris/vm/osThread_solaris.hpp
No comments.
src/os/solaris/vm/os_solaris.cpp
No comments.
src/os/solaris/vm/os_solaris.hpp
No comments.
src/os/windows/vm/os_windows.cpp
No comments.
src/os/windows/vm/os_windows.inline.hpp
No comments.
src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp
No comments.
src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp
No comments.
src/share/vm/runtime/arguments.cpp
No comments.
src/share/vm/runtime/os.hpp
No comments.
src/share/vm/runtime/safepoint.cpp
No comments.
src/share/vm/runtime/sharedRuntime.cpp
No comments.
src/share/vm/runtime/sharedRuntime.hpp
No comments.
Dan
>
> Regards,
>
> Fred
>
> On 04/01/2014 08:27 AM, David Holmes wrote:
>> Hi Fred,
>>
>> This looks okay to me. Great to see so much red :) Probably worth
>> mentioning to other readers that you're going to re-examine the use of
>> yield_all() in the future.
>>
>> Minor nit in os_solaris.cpp:
>>
>> void os::yield_all() {
>> // Yields to all threads, including threads with lower priorities
>> os::sleep(Thread::current(), 1, false);
>> }
>>
>> the indent for sleep needs to be 4 spaces less now.
>>
>> Thanks,
>> David
>>
>> On 31/03/2014 10:25 PM, frederic parain wrote:
>>> Greetings,
>>>
>>> Back in Solaris 8 days, the JVM used a thread library
>>> called T1. In Solaris 9, a new thread library, called T2,
>>> was added to Solaris. The JVM code was extended to be able
>>> to use either the T1 libthread or the T2 libthread.
>>> Since Solaris 10, T2 is the default thread library and the
>>> T1 libthread is not part of Solaris anymore, all its APIs
>>> are wrappers around T2 APIs. This changeset removes the
>>> support for the T1 libthread and the workarounds put in
>>> VM code to deal with some T1 issues.
>>>
>>> Note: the minimal requirement for JDK9 is Solaris 10u9.
>>>
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8038473
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~fparain/8038473/webrev.00/
>>>
>>> Thank you,
>>>
>>> Fred
>>>
>
More information about the hotspot-runtime-dev
mailing list