RFR(XXS) 6664815: Eliminate redundant memcpy operation in jni_GetStringUTFRegion

[David Holmes]

On 4/04/2014 8:54 PM, Marcus Larsson wrote:
> Good point,
>
> Updated: http://cr.openjdk.java.net/~dsimms/6664815/
> <http://cr.openjdk.java.net/%7Edsimms/6664815/>
>
> Still looking for one more review for this.

Looks okay to me.

David
-----

> Thanks,
> Marcus
>
> On 04/04/2014 09:30 AM, Ivan Gerasimov wrote:
>> Hi Marcus!
>>
>> While it's not critical and not really connected to the issue you're
>> solving, wouldn't it be better to replace
>> 344     p = utf8_write(p, base[index]);
>> with
>> 344     p = utf8_write(p,*c*);
>> in src/share/vm/utilities/utf8.cpp?
>>
>> Sincerely yours,
>> Ivan
>>
>>
>> On 03.04.2014 17:17, Marcus Larsson wrote:
>>> Hello,
>>>
>>> I would like reviews for the following bugfix removing a redundant
>>> memcpy.
>>> Built on all platforms and tested with JCK.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~dsimms/6664815/
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-6664815
>>>
>>> Regards,
>>> Marcus
>>>
>>>
>>
>