RFR (S): 8039146: Fix 64-bit store to int JNIHandleBlock::_top

[Vladimir Kozlov]

Turns out that we don't need closed changes. We can push this as it is.

Thanks,
Vladimir

On 4/7/14 2:20 PM, Lindenmaier, Goetz wrote:
> Thanks for the review, Vladimir!
>
> Best regards,
>    Goetz
>
> -----Original Message-----
> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> Sent: Monday, April 07, 2014 7:56 PM
> To: hotspot-runtime-dev at openjdk.java.net
> Cc: Lindenmaier, Goetz
> Subject: Re: RFR (S): 8039146: Fix 64-bit store to int JNIHandleBlock::_top
>
> Fix is good but it requires closed changes which we need to prepare
> before the push.
>
> Thanks,
> Vladimir
>
> On 4/7/14 10:41 AM, Coleen Phillimore wrote:
>>
>> The change looks fine.  I can sponsor it unless someone else would like to.
>> Thanks,
>> Coleen
>>
>> On 4/7/14, 6:07 AM, Lindenmaier, Goetz wrote:
>>>
>>> Hi,
>>>
>>> could I please get a review of this change?  It fixes a rather
>>>
>>> obvious error, and is really simple.
>>>
>>> Is runtime the wrong mainling list for interpreter changes? Should I
>>>
>>> post to comp?
>>>
>>> Best regards,
>>>
>>> Goetz.
>>>
>>> *From:*Lindenmaier, Goetz
>>> *Sent:* Donnerstag, 3. April 2014 15:33
>>> *To:* hotspot-runtime-dev at openjdk.java.net
>>> *Subject:* RFR (S): 8039146: Fix 64-bit store to int JNIHandleBlock::_top
>>>
>>> Hi,
>>>
>>> please review an test this small fix to the interpreters.  I please need
>>>
>>> a sponsor.
>>>
>>> http://cr.openjdk.java.net/~goetz/webrevs/8039146-intSt/webrev.00/
>>> <http://cr.openjdk.java.net/%7Egoetz/webrevs/8039146-intSt/webrev.00/>
>>>
>>> JNIHandleBlock::_top is an int field. Various places store into
>>>
>>> this field using a pointer store. On 64-bit platforms
>>>
>>> this can cause errors.
>>>
>>> This change adapts the corresponding operations on sparc
>>>
>>> and both x86 variants to use fixed 32-bit operations.
>>>
>>> Best regards,
>>>
>>>    Goetz.
>>>
>>