RFR (XS) JDK-8038076: constraint on multianewarray instruction is not checked since class version 50

Lois Foltan lois.foltan at oracle.com
Fri Apr 11 14:06:10 UTC 2014


On 4/11/2014 9:54 AM, Keith McGuigan wrote:
> D'oh!  That'd be my bad.  Darn off-by-one errors.  Fix looks good, 
> thanks for doing it!

Hi Keith,
No problem.  Thanks for reviewing!
Lois

>
> --
> - Keith
>
>
> On Fri, Apr 11, 2014 at 9:19 AM, Lois Foltan <lois.foltan at oracle.com 
> <mailto:lois.foltan at oracle.com>> wrote:
>
>     Hello,
>
>     Please review the following fix:
>
>     Webrev:
>     http://cr.openjdk.java.net/~lfoltan/bug_jdk8038076/
>     <http://cr.openjdk.java.net/%7Elfoltan/bug_jdk8038076/>
>
>     Bug: constraint on multianewarray instruction is not checked since
>     class version 50
>     https://bugs.openjdk.java.net/browse/JDK-8038076
>
>     Summary of fix:
>     The incorrect placement of a post increment operator was causing
>     the calculated dimensions of a multianewarray bytecode to be 1
>     greater than reality.  The end result of this bug was that a
>     VerifyError would not be correctly generated if the multianewarray
>     bytecode contained an array type descriptor that was 1 dimension
>     smaller than the number of dimensions specified.  Thank you to
>     Christian Tornqvist for writing the test case included.
>
>     Tests:
>           - jtreg hotspot/test/*, JDK java.lang & java.util,
>     vm.quick.testlist, JCK lang tests
>           - JCK vm in progress
>
>     Thank you,
>     Lois
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20140411/3a935432/attachment.html>


More information about the hotspot-runtime-dev mailing list