RFR (S) 8039904: dtrace/hotspot/Monitors/Monitors001 fails with "assert(s > 0) failed: Bad size calculated"

[Coleen Phillimore]

Thanks Harold.
Coleen

On 4/11/14, 12:25 PM, harold seigel wrote:
> Hi Coleen,
>
> You changes look good.
>
> Harold
>
> On 4/11/2014 12:22 PM, Coleen Phillimore wrote:
>>
>> On 4/11/14, 12:00 PM, Keith McGuigan wrote:
>>> Looks good, but why are you not using a newer version of webrev with 
>>> "next" links??
>>
>> Thanks Keith.  The private copy I had of the "next" link webrev that 
>> I had broke for me for some mysterious reason.  I filed a bug to see 
>> if the "official" version of webrev could have "next" links instead 
>> of debugging my own.
>> Thanks!
>> Coleen
>>
>>>
>>> --
>>> - Keith
>>>
>>>
>>> On Fri, Apr 11, 2014 at 10:48 AM, Coleen Phillimore 
>>> <coleen.phillimore at oracle.com <mailto:coleen.phillimore at oracle.com>> 
>>> wrote:
>>>
>>>     Summary: Dtrace monitoring uses size before mirror size is set.
>>>
>>>     The refactoring I did for bug
>>>     https://bugs.openjdk.java.net/browse/JDK-8028497 caused this
>>>     bug. The size of the mirror is filled in by the
>>>     InstanceMirrorKlass allocation but was used for dtrace probes
>>>     before it in the normal allocation pass.  Pass the allocated
>>>     size to dtrace function instead.
>>>
>>>     Tested by dtrace tests on solaris sparcv9, testbase
>>>     vm.quick.testlist also.
>>>
>>>     open webrev at http://cr.openjdk.java.net/~coleenp/8039904/
>>>     <http://cr.openjdk.java.net/%7Ecoleenp/8039904/>
>>>     bug link https://bugs.openjdk.java.net/browse/JDK-8039904
>>>
>>>     Thanks,
>>>     Coleen
>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20140411/d7f2e028/attachment-0001.html>