RFR(S) : 8051896 : jtreg tests don't use $TESTJAVAOPTS

[Christian Tornqvist]

Hi Igor,

The test/runtime/7162488/Test7162488.sh shouldn't be passing on options at all, the test will fail if someone passed in -XX:+IgnoreUnrecognizedVMOptions (which is done in our testing).  Otherwise the change looks good.

Thanks,
Christian

-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Igor Ignatyev
Sent: Tuesday, July 29, 2014 7:15 PM
To: hotspot-runtime-dev
Cc: hotspot-dev developers
Subject: Re: RFR(S) : 8051896 : jtreg tests don't use $TESTJAVAOPTS

Can I have a 2nd review of this changes? I'd prefer to get it from someone from runtime team, since there are several runtime tests are touched.

updated webrev: http://cr.openjdk.java.net/~iignatyev/8051896/webrev.02/

Igor

On 07/25/2014 01:38 AM, Vladimir Kozlov wrote:
> The order of flags on command line is important. I think TESTJAVAOPTS 
> should be last to take priority:
>
> TESTOPTS="${TESTVMOPTS} ${TESTJAVAOPTS}"
>
> Please, add copyright headers to files in compiler/6894807.
>
> Otherwise look good.
>
> Thanks,
> Vladimir
>
> On 7/24/14 1:37 PM, Igor Ignatyev wrote:
>> // was Re: RFR(XS) : 8051896 : compiler/ciReplay tests don't use
>> $TESTJAVAOPTS:
>>
>> updated webrev: 
>> http://cr.openjdk.java.net/~iignatyev/8051896/webrev.01/
>> 93 lines changed: 15 ins; 40 del; 38 mod;
>>
>> On 07/24/2014 10:18 PM, Vladimir Kozlov wrote:
>>> Looks good.
>>>
>>> Is not this a general problem for all our tests? They use only 
>>> TESTVMOPTS.
>> Yeap, it's a general problem, I've updated all tests.
>> I thought jtreg merges TESTVMOPTS and TESTJAVAOPTS flags
>>> together.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 7/24/14 11:04 AM, Igor Ignatyev wrote:
>>>> http://cr.openjdk.java.net/~iignatyev/8051896/webrev.00/
>>>> 12 lines changed: 2 ins; 0 del; 10 mod
>>>>
>>>> Hi all,
>>>>
>>>> Please review patch:
>>>>
>>>> Problem:
>>>> the tests use only TESTVMOPTS, but jtreg propagates some flags by 
>>>> TESTJAVAOPTS variable
>>>>
>>>> Fix:
>>>> usages of TESTVMOPTS were replaced by TESTOPTS which is initialized 
>>>> as concatenated values of TESTVMOPTS and TESTJAVAOPTS
>>>>
>>>> jbs: https://bugs.openjdk.java.net/browse/JDK-8051896
>>>> testing: jprt