RFR(XS) 8055236: Deadlock during NMT2 shutdown on Windows

[Zhengyu Gu]

Thanks for the review.

-Zhengyu

On 8/20/2014 3:52 PM, Christian Tornqvist wrote:
> Hi Zhengyu,
>
> This looks good.
>
> Thanks,
> Christian
>
> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Zhengyu Gu
> Sent: Wednesday, August 20, 2014 3:11 PM
> To: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: RFR(XS) 8055236: Deadlock during NMT2 shutdown on Windows
>
> Thanks for the quick review.
>
> -Zhengyu
>
> On 8/20/2014 2:17 PM, Yumin Qi wrote:
>> Look good!
>>
>> Thanks
>> Yumin
>>
>> On 8/20/2014 6:21 AM, Zhengyu Gu wrote:
>>> The problem is caused by acquiring locks inside
>>> MemTracker::shutdown(), which could be held by threads that have been
>>> already killed.
>>>
>>> Given the MemTracker::shutdown() call is on JVM exiting path, the
>>> call is not necessary, should be removed.
>>>
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8055236
>>> Webrev: http://cr.openjdk.java.net/~zgu/8055236/webrev.00/
>>> <http://cr.openjdk.java.net/%7Ezgu/8055236/webrev.00/>
>>>
>>>
>>> Test:
>>>     Tested on Windows x64 with following tests:
>>>       nsk/jvmti/scenarios/allocation
>>>       runtime/ParallelClassLoading
>>>
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>