RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

[Daniel D. Daugherty]

On 8/20/14 1:36 PM, Ivan Gerasimov wrote:
> Hello everyone!
>
> Here's the third version of the webrev:
> http://cr.openjdk.java.net/~igerasim/8055338/2/webrev/

src/os/windows/vm/os_windows.cpp
     line 444:  res = java_lang_Thread::is_daemon(java_thread->threadObj())
     line 453:  thread->run();
         Querying the 'is_daemon' flag before the thread is run
         won't catch all cases of daemon threads, but I think
         it is good enough for our purposes.

src/share/vm/runtime/java.cpp
     No comments.

Thumbs up.

> The control build of the previous one was causing a lot of test failures.
> This one seems to be innocent enough: no new test failures so far.

So the previous version was querying everything after the
thread had finished with thread->run(). I'll take it the
data we were querying was no longer stable at that point?


> Additionally, this version keeps the timing around the thread exit 
> close to original, which might be important if we deal with a race.

Agreed.

Dan


>
> Sincerely yours,
> Ivan
>