RFR(S): 8041727 - [TESTBUG] runtime/jsig/Test8017498.sh fails with Test8017498.sh: 50: [: x/usr/bin/gcc: unexpected operator

[Daniel D. Daugherty]

 > http://cr.openjdk.java.net/~ctornqvi/webrev/8041727/webrev.00/

test/runtime/jsig/Test8017498.sh
     line 37: if [ -z "${TESTSRC}" ]; then
         Style nit: If you quote the shell vars, then '{' and '}'
             are typically not used. (I personally don't use them
             at all since I quote liberally).

     line 61:             EXTRA_CFLAG=-m32
         Indented too much.

Thumbs up.

Dan


On 8/22/14 7:31 AM, Christian Tornqvist wrote:
> Hi everyone,
>
>   
>
> Fixed shell compatibility issues in runtime/jsig/Test8017498.sh (based on
> patch supplied by Andrey Zakharov). Also fixed an issue where gcc may fail
> because the machine it runs on doesn't have the right packages installed for
> compiling 32bit binaries.
>
>   
>
> Webrev:
>
> http://cr.openjdk.java.net/~ctornqvi/webrev/8041727/webrev.00/
>
>   
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8041727
>
>   
>
> Thanks,
>
> Christian
>