RFR(XS): 8053995: Add method to WhiteBox to get vm pagesize.

[Yumin Qi]

Too late! It is pushed before I saw this email.
I will take care of this (if it happens or not), file a bug to fix it.

Thanks
Yumin

On 11/26/2014 4:57 PM, David Holmes wrote:
> On 27/11/2014 3:36 AM, Yumin Qi wrote:
>> Thanks for the review. Yes, the test will build testlibrary with
>>
>> @library /testlibrary /testlibrary/whitebox
>
> No that won't necessarily build the testlibrary.
>
> From other email:
>
> >> I'm having a problem running a test in 8u25 that uses the testlibrary
> >> ProcessTools API. I get a ClassNotFoundException. Looking in the
> >> classes directory I only see two testlibrary classes - which map to
> >> two specific testlibrary classes that one test has on its @build
> >> line. The test in question simply has:
> >>
> >> @library /testlibrary
> >>
> >> Does it need an explicit:
> >>
> >> @build com.oracle.java.testlibrary.*
> >
> > Yes. It turns out that JTReg might not compile the library classes on
> > demand (but it does sometimes). So it is better to specify the
> > required build manually.
> >
> > -JB-
>
> David
> -----
>
>>
>> Thanks
>> Yumin
>>
>>
>>
>> On 11/25/14, 5:54 PM, David Holmes wrote:
>>> Hi Yumin,
>>>
>>> On 26/11/2014 11:36 AM, Yumin Qi wrote:
>>>> Please review
>>>>
>>>> bugs: https://bugs.openjdk.java.net/browse/JDK-8053995
>>>> webrev: http://cr.openjdk.java.net/~minqi/8053995/webrev01/
>>>
>>> The test also needs to ensure the testlibrary gets built.
>>>
>>> Otherwise seems okay.
>>>
>>> Thanks,
>>> David
>>>
>>>> Now the API usage is in internal test case, see separate email for the
>>>> webrev.
>>>>
>>>> It is same as previous version (webrev00).
>>>>
>>>> Thanks
>>>> Yumin
>>>>
>>>> On 7/31/14, 3:29 PM, Yumin Qi wrote:
>>>>> Please review:
>>>>>
>>>>> http://cr.openjdk.java.net/~minqi/8053995/webrev00/
>>>>>
>>>>> Summary: Currently there is no java API to get underlying OS 
>>>>> native VM
>>>>> page size unless using Unsafe which is not recommended. The new added
>>>>> method to WhiteBox can read this property and used in test.
>>>>>
>>>>>
>>>>> Tests: JPRT and  jtreg.
>>>>>
>>>>> Thanks
>>>>> Yumin