RFR(XXS): 8067015: Implement os::pd_map_memory() on AIX

Volker Simonis volker.simonis at gmail.com
Wed Dec 10 17:21:17 UTC 2014


Hi Alejandro,

can I push this change to jdk9/dev/hotspot?

It fixes a problem which arose after the integration of the modularity
stuff into jdk9/dev

And it only touches a single AIX-only file (so no side effects on any
other platforms)

Thanks,
Volker


On Wed, Dec 10, 2014 at 7:29 AM, David Holmes <david.holmes at oracle.com> wrote:
> Hi Volker,
>
> On 10/12/2014 3:39 AM, Volker Simonis wrote:
>>
>> Hi,
>>
>> could I please get a review for the following trivial change which
>> simply implements os::pd_map_memory() on AIX:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/8067015/
>>
>> Until now os::pd_map_memory() was only used in the context of class
>> data sharing (CDS) which isn't supported on AIX anyway, so we hadn't
>> implemented it in os_aix.cpp
>>
>> However with the integration of the modularity change,
>> os::pd_map_memory() is now also needed for the loading of image files.
>>
>> The implementation is a straightforward copy of the corresponding Linux
>> version.
>
>
> Change looks fine to me.
>
>> I'd like to push this directly to jdk9/dev/hotspot because it was
>> introduced there and because it affects all our AIX builds. I hope
>> that's no problem, especially because the change only touches an
>> AIX-only files.
>
>
> Need to check this with Alejandro - cc'd.
>
> Thanks,
> David
>
>
>> Thank you and best regards,
>> Volker
>>
>


More information about the hotspot-runtime-dev mailing list