RFR(s): 8067187: -XX:MaxMetaspaceSize=20m -Xshare:dump caused JVM to crash

[Calvin Cheung]

Hi Misha,

I ran the jtreg test via jprt and it passed in all platforms.
I'll leave the testcase as is.

thanks,
Calvin

On 12/15/2014 10:43 AM, Mikhailo Seledtsov wrote:
> Hi Calvin,
>
>  The changes look fine to me, except for one item.
>
> output.shouldContain("is not large enough.\nEither don't specify the 
> -XX:MaxMetaspaceSize=<size>\nor increase the size to at least");
> Please make sure the match with  "\n" works well on Windows as well as 
> on Linux. Alternatively, you could expand this to three matches, to 
> make the test more robust:
>     output.shouldContain("is not large enough");
>     output.shouldContain("Either don't specify the 
> -XX:MaxMetaspaceSize=");
>     output.shouldContain("or increase the size to at least");
>
> If you choose to make this change, no need to re-post the webrev.
>
> Thank you,
> Misha
>
>
> On 12/12/2014 12:42 PM, Calvin Cheung wrote:
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8067187
>>
>> This fix is to add a check on the MaxMetaspaceSize when performing 
>> CDS archive dumping.
>>
>> With the fix, instead of a crash, it will print and error message 
>> like the following and exit:
>>
>> Java HotSpot(TM) 64-Bit Server VM warning:
>> The MaxMetaspaceSize of 20971520 bytes is not large enough.
>> Either don't specify the -XX:MaxMetaspaceSize=<size>
>> or increase the size to at least 33554432.
>>
>> Tested manually via command line and jtreg test on the new test.
>>
>> webrev: http://cr.openjdk.java.net/~ccheung/8067187/webrev/
>>
>> thanks,
>> Calvin
>