RFR(XS): 8066814: Reduce accessibility in TraceEvent

Staffan Larsen staffan.larsen at oracle.com
Thu Dec 18 08:10:40 UTC 2014


Looks good!

Thanks,
/Staffan

> On 17 dec 2014, at 15:45, Markus Grönlund <markus.gronlund at oracle.com> wrote:
> 
> Greetings,
>  
> Kindly asking for reviews for the following changeset:
>  
> Bug: https://bugs.openjdk.java.net/browse/JDK-8066814 <https://bugs.openjdk.java.net/browse/JDK-8066814>
> Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/ <http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/>
>  
> Description:
> TraceEvent currently exposes internals unnecessarily.
>  
> Therefore:
>  
> Remove unnecessarily exposed methods. 
> Add assert for not committing a cancelled event. 
> Add method stubs for !INCLUDE_TRACE
>  
> Thanks in advance
> Markus



More information about the hotspot-runtime-dev mailing list