8067947 - Regression test for JDK-6522873

[Jesper Wilhelmsson]

Hi Christian,

Thanks for looking at this!

You are right. My initial thought was to reuse the ErrorOnStart class in other 
tests but it doesn't really add any value since the provided functionality is 
fairly simple.

I removed the class and changed the test according to your suggestion.
A new webrev is available here:

http://cr.openjdk.java.net/~jwilhelm/8067947/webrev.01/

Thanks!
/Jesper


Christian Tornqvist skrev 19/12/14 17:05:
> Hi Jesper,
>
> I don't think you need to add the ErrorOnStart class in testlibrary, you
> should be able to replace it by just doing the following in the test for
> loop:
>
> 	String testOption = option + "junk";
> 	ProcessBuilder pb =
> ProcessTools.createJavaProcessBuilder(testOption, "-version");
> 	new OutputAnalyzer(pb.start())
> 		.shouldContain("Unrecognized option: " + testOption)
> 		.shouldHaveExitValue(1);
>
> Thanks,
> Christian
>
> -----Original Message-----
> From: hotspot-runtime-dev
> [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Jesper
> Wilhelmsson
> Sent: Friday, December 19, 2014 10:54 AM
> To: hotspot-runtime-dev
> Subject: RFR: 8067947 - Regression test for JDK-6522873
>
> Hi,
>
> Please review this regression test for the command line flags that no longer
> allow arbitrary junk characters at the end.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8067947
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8067947/webrev.00/
>
> Thanks,
> /Jesper
>