RFR: JDK-8026126 and others - Solaris and Linux code cleanup

Gerald Thornbrugh gerald.thornbrugh at oracle.com
Wed Feb 5 08:41:47 PST 2014


Hi Daniel,
> > http://cr.openjdk.java.net/~coleenp/linux-cleanup/
>
> src/os/linux/vm/os_linux.cpp
>     No comments.
>
> src/os/linux/vm/perfMemory_linux.cpp
>     No comments.
>
>
> > http://cr.openjdk.java.net/~coleenp/solaris-cleanup/
>
> src/os/solaris/vm/os_solaris.cpp
>     No comments.
>
> src/os/solaris/vm/perfMemory_solaris.cpp
>     No comments.
>
> src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp
>     No comments.
>
> Thumbs up.
>
> I presume you got no push back on dropping the assert() for
> the return value from ::close().
Correct.

Thanks for the code review.

Gerald
>
> Dan
>
>
> On 2/5/14 7:47 AM, Gerald Thornbrugh wrote:
>> Hi,
>>
>> I am a member of the Oracle Hotspot group and there is an initiative 
>> to clean up
>> things like uninitialized variables and unclosed file descriptors in 
>> JDK9.  I have run
>> UTE and JPRT tests on Solaris and Linux test machines. The below 
>> webrevs show
>> the cleanup in some of the Solaris and Linux source areas.
>>
>> The Linux cleanup changes:
>>
>> Bugs:
>> https://bugs.openjdk.java.net/browse/JDK-8026126
>> https://bugs.openjdk.java.net/browse/JDK-8025497
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~coleenp/linux-cleanup/
>>
>> The Solaris cleanup changes:
>>
>> Bugs:
>> https://bugs.openjdk.java.net/browse/JDK-8025481
>> https://bugs.openjdk.java.net/browse/JDK-8029777
>> https://bugs.openjdk.java.net/browse/JDK-8025665
>>
>> Webrev:
>> http://cr.openjdk.java.net/~coleenp/solaris-cleanup/
>>
>> Please review my changes and let me know if you have questions.
>>
>> Thanks,
>>
>> Gerald Thornbrugh
>



More information about the hotspot-runtime-dev mailing list