RFR(XS): JDK-8030808 dtrace/hotspot/Monitors/Monitors001 fails in product builds on solaris-sparc

Daniel D. Daugherty daniel.daugherty at oracle.com
Thu Feb 6 06:40:12 PST 2014


Thanks for updating the comment.

Dan


On 2/6/14 2:45 AM, Frederic Parain wrote:
> Here's the new webrev:
>
> http://cr.openjdk.java.net/~fparain/8030808/webrev.01/
>
> Fred
>
> On 02/06/2014 10:33 AM, Frederic Parain wrote:
>> Hi Dan,
>>
>> I'll update the comment.
>>
>> Fred
>>
>> On 02/06/2014 01:35 AM, Daniel D. Daugherty wrote:
>>> On 2/5/14 7:23 AM, Frederic Parain wrote:
>>>> Greetings,
>>>>
>>>> Please review this small fix for bug 8030808.
>>>> The bug is caused by a compiler bug preventing the
>>>> hotspot:::monitor-waited DTrace probe to be fired
>>>> on SPARC. After several failed attempts to fix
>>>> the compiler behavior with #pragma and flags, I'm
>>>> proposing this simple workaround.
>>>>
>>>> CR:
>>>> https://bugs.openjdk.java.net/browse/JDK-8030808
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~fparain/8030808/webrev.00/
>>>
>>>
>>> src/share/vm/runtime/synchronizer.hpp
>>>      No comments.
>>>
>>> src/share/vm/runtime/synchronizer.cpp
>>>      Can you change this comment:
>>>
>>>      389   /* This dummy call is in place to get around dtrace bug
>>> 6254741.  Once
>>>      390      that's fixed we can uncomment the following line and
>>> remove the call */
>>>
>>>      to:
>>>
>>>      389   // This dummy call is in place to get around dtrace bug
>>> 6254741.  Once
>>>      390   // that's fixed we can uncomment the following line, remove
>>> the call
>>>            // and change this function back into a "void" func.
>>>
>>> Thanks.
>>>
>>> Dan
>>>
>>>
>>>
>>>>
>>>> The fix has been tested with the dtrace/hotspot test suite
>>>> and the vm.quick testlist.
>>>>
>>>> Thanks,
>>>>
>>>> Fred
>>>>
>>>
>>
>



More information about the hotspot-runtime-dev mailing list