code review round 0 for minor FDS makefile fix (8033714)

Doug Simon doug.simon at oracle.com
Thu Feb 6 08:29:02 PST 2014


Not sure if I’m being asked for a review, but if so, looks good.

On Feb 6, 2014, at 5:07 PM, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:

> Looks good to me too.  Thanks for fixing this.
> 
> tom
> 
> On Feb 6, 2014, at 6:07 AM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> 
>> On 2/5/14 9:28 PM, David Holmes wrote:
>>> Hi Dan,
>>> 
>>> Looks good to me.
>> 
>> Thanks for the review!
>> 
>> 
>>> (I never run the install targets :( )
>> 
>> Neither do I and apparently neither does JPRT... That's how this
>> slipped through the cracks...
>> 
>> Dan
>> 
>> 
>>> 
>>> Thanks,
>>> David
>>> 
>>> On 6/02/2014 9:20 AM, Daniel D. Daugherty wrote:
>>>> This code review request is going to three different aliases.
>>>> Don't use Thunderbird's "reply to list" option since it will
>>>> pick just _one_ of the _three_ lists.
>>>> 
>>>> 
>>>> Greetings,
>>>> 
>>>> Doug Simon and Tom Rodriguez have sent a Full Debug Symbols (FDS)
>>>> makefile fix our way. Here are the bug and webrev URLs:
>>>> 
>>>> http://cr.openjdk.java.net/~dcubed/8033714-webrev/0-jdk9-hs-runtime/
>>>> 
>>>>    8033714 hotspot 'install_jvm' bld target broken with
>>>> ZIP_DEBUGINFO_FILES=0
>>>>    https://bugs.openjdk.java.net/browse/JDK-8033714
>>>> 
>>>> As you might guess from the bug synopsis, this fix is needed when
>>>> building without ZIP'ing the debuginfo files (ZIP_DEBUGINFO_FILES=0).
>>>> Based on the Graal project fix, I've updated a few other places where
>>>> building with FDS disabled is affected.
>>>> 
>>>> As always, comments and suggestions are welcome.
>>>> 
>>>> Dan
>> 
> 



More information about the hotspot-runtime-dev mailing list