FRF: 8033792: AltHashing used jint for imprecise bit shifting

Yumin Qi yumin.qi at oracle.com
Thu Feb 6 22:30:10 PST 2014


I made a small mistake in 'Subject': it should be RFR (Request For 
Review), type fast!

Thanks
Yumin

On 2/6/2014 8:14 PM, Yumin Qi wrote:
> Hi,
>
>   Please review the change for 8033792.
>
>   Summary:  AltHashing uses 'jint' type in the way as 'unsigned int'  
> in bit shifting, which is imprecise.  This could lead loss of 
> precision when converted between jint and 'unsigned int' during bit 
> operation. Fix by changing operation variable type from 'jint' to 
> 'juint', before return, cast it into type 'jint'.
>
> http://cr.openjdk.java.net/~minqi/8033792/webrev00/
>
> Thanks
> Yumin



More information about the hotspot-runtime-dev mailing list