RFR (XS): JDK-8033990: Add message to verbose output to indicate when JVM was unable to use shared archive (with -Xshare:auto)

Mikhailo Seledtsov mikhailo.seledtsov at oracle.com
Wed Feb 12 10:35:15 PST 2014


Hi Coleen,

  Thank you for the review. Would it be OK if I print the message that 
comes thru after the message that I introduced?

There is a variety of messages that are passed to fail_continue() 
depending on who calls it; checking/asserting on each message in the 
test would be a large overhead; also some of these messages do not 
convey "attempted, but failed" meaning.

Thank you,
Misha

On 2/12/2014 10:40 AM, Coleen Phillimore wrote:
>
> Misha,
> There is a message that comes through to fail_continue().   Why don't 
> you use that message?
> thanks,
> Coleen
>
> On 2/7/14 4:55 PM, Mikhailo Seledtsov wrote:
>> Please review this small change that improves testability of CDS, and 
>> will aid in fixing several intermittently failing CDS tests.
>>
>>     JBS: https://jbs.oracle.com/bugs/browse/JDK-8033990
>>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8033990/webrev.00/
>>     Testing:
>>         Basic testing:
>>             - ran "Xshare:auto -version", "-XX:+Verbose 
>> -XX:+PrintMiscellaneous -Xshare:auto -version" before and after the 
>> archive was created
>>             - ran "XX:+Verbose -XX:+PrintMiscellaneous -Xshare:auto 
>> -version" on Windows where ASLR occasionally prevents sharing
>>
>>         JT-Reg: runtime/SharedArchiveFile, with and w/o the 
>> additional options -vmoptions:"-XX:+Verbose -XX:+PrintMiscellaneous"
>>
>>         Tonga: a sub-set of vm.parallel_class_loading.testlist, with 
>> -Xshare:auto -XX:+Verbose -XX:+PrintMiscellaneous -showversion"
>>                      Tonga (vm.parallel_class_loading.testlist 
>> -vmopts " -Xshare:auto -XX:+Verbose -XX:+PrintMiscellaneous 
>> -showversion")
>>             - ongoing. Plan not to run full testlist since the change 
>> is small and trivial
>>
>>         JPRT: standard JPRT: 2014-02-07-210345.mseledtsov.work01
>>             - ongoing
>>
>> Thank you,
>> Misha
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20140212/0e1ece68/attachment.html 


More information about the hotspot-runtime-dev mailing list