RFR: 8028785: code cleanup for hotspot.src.share.vm.prims: JNI exception pending

Calvin Cheung calvin.cheung at oracle.com
Wed Feb 12 18:49:28 UTC 2014


Coleen,

Thanks for your review.
I've updated the webrev with your suggestions.
webrev: http://cr.openjdk.java.net/~ccheung/8028785/webrev/

previous webrev: http://cr.openjdk.java.net/~ccheung/8028785/webrev.00/

Calvin

On 2/12/2014 7:39 AM, Coleen Phillimore wrote:
>
> This looks good.   You could rename these to be consistent with CHECK 
> macros and save characters in the code.
> thanks,
> Coleen
>
> *CHECK_JNI_EXCEPTION_RETURN_VALUE
> to
> CHECK_JNI_EXCEPTION_()   with underscore
>
> and
>
> CHECK_JNI_EXCEPTION_RETURN
> to
> CHECK_JNI_EXCEPTION()
> *
> On 2/10/14 2:56 PM, Calvin Cheung wrote:
>> This fix is for adding JNI exception pending check in several files 
>> under src/share/vm/prims directory.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8028785 (non-open bug)
>>
>> webrev: http://cr.openjdk.java.net/~ccheung/8028785/webrev/
>>
>> Tests:
>>     jprt
>>     vm.quick (on linux-x64)
>>
>> Please review.
>>
>> thanks,
>> Calvin
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20140212/bb031cb5/attachment.html 


More information about the hotspot-runtime-dev mailing list