RFR 7014526: "java -version" crash on sparc with some values of HeapBaseMinAddress

[David Holmes]

On 19/02/2014 4:30 AM, Coleen Phillimore wrote:
>
> I fixed the indentation already but this changeset has the better
> message suggested by Thomas.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/7014526_2/

Test indentation still off at the end:

       largePagesTest();
         heapBaseMinAddressTest();
       sharingTest();

otherwise looks okay to me.

David
-----

> java -d64 -XX:HeapBaseMinAddress=128M -XX:+PrintMiscellaneous
> -XX:+Verbose -version
> ...
> HeapBaseMinAddress must be at least 6442450944 (6G) which is greater
> than value given 134217728
> ...
>
> thanks,
> Coleen
>
>
> On 2/18/14 12:58 PM, Vladimir Kozlov wrote:
>> Coleen,
>>
>> Where is link to new version?
>> The indent in test was also off.
>>
>> Thanks,
>> Vladimir
>>
>> On 2/18/14 6:54 AM, Coleen Phillimore wrote:
>>>
>>> I fixed the indentation and I changed it to %d because it's %dM.  The %x
>>> was temporary for my debugging.
>>>
>>> Thanks!
>>> Coleen
>>>
>>> On 2/17/14 8:43 PM, Vladimir Kozlov wrote:
>>>> Coleen,
>>>>
>>>> %x is not correct formal for this value.
>>>> Indent of all if() is off by 1 space.
>>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>> On 2/17/14 4:42 PM, Coleen Phillimore wrote:
>>>>> Summary: Make default HeapBaseMinAddress the minimum that can be
>>>>> specified.
>>>>>
>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/7014526/
>>>>> bug link https://bugs.openjdk.java.net/browse/JDK-7014526
>>>>>
>>>>> Tested with hotspot jtreg tests and some testbase compressed oops
>>>>> tests.
>>>>>
>>>>> Thanks,
>>>>> Coleen
>>>
>