RFR 7014526: "java -version" crash on sparc with some values of HeapBaseMinAddress

[Coleen Phillimore]

I *thought* I'd fixed the indentation in the test so it wasn't showing 
the whitespace diffs, but in fact I meant to fix the indentation and 
somehow didn't.   Sorry, it's fixed now.   The main function was only 
indented by 2 not 4.

Thanks,
Coleen

On 2/18/14 3:03 PM, Yumin Qi wrote:
> Hi, Coleen
>
> On 2/18/2014 10:30 AM, Coleen Phillimore wrote:
>>
>> I fixed the indentation already but this changeset has the better 
>> message suggested by Thomas.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/7014526_2/
>>
> 142 smallHeapTest();
> 143 smallHeapTestWith3G();
> 144 largeHeapTest();
> 145 largePagesTest();
> 146   heapBaseMinAddressTest();    <---- ident here seems o have two 
> more spaces.
> 147 sharingTest();
> ...
>
> Thanks
> Yumin
>> HeapBaseMinAddress must be at least 6442450944 (6G) which is greater 
>> than value given 134217728
>> ...
>>
>> thanks,
>> Coleen
>>
>>
>> On 2/18/14 12:58 PM, Vladimir Kozlov wrote:
>>> Coleen,
>>>
>>> Where is link to new version?
>>> The indent in test was also off.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 2/18/14 6:54 AM, Coleen Phillimore wrote:
>>>>
>>>> I fixed the indentation and I changed it to %d because it's %dM.  
>>>> The %x
>>>> was temporary for my debugging.
>>>>
>>>> Thanks!
>>>> Coleen
>>>>
>>>> On 2/17/14 8:43 PM, Vladimir Kozlov wrote:
>>>>> Coleen,
>>>>>
>>>>> %x is not correct formal for this value.
>>>>> Indent of all if() is off by 1 space.
>>>>>
>>>>> Thanks,
>>>>> Vladimir
>>>>>
>>>>> On 2/17/14 4:42 PM, Coleen Phillimore wrote:
>>>>>> Summary: Make default HeapBaseMinAddress the minimum that can be
>>>>>> specified.
>>>>>>
>>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/7014526/
>>>>>> bug link https://bugs.openjdk.java.net/browse/JDK-7014526
>>>>>>
>>>>>> Tested with hotspot jtreg tests and some testbase compressed oops 
>>>>>> tests.
>>>>>>
>>>>>> Thanks,
>>>>>> Coleen
>>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20140218/0c8cd4eb/attachment-0001.html