RFR(XS): JDK-8034867 - Object references from expression stack are not visible as roots via jvmti FollowReferences and HeapDump

[serguei.spitsyn at oracle.com]

Hi Axel,

We decided that I will sponsor your change.
My current plan is to test and push it over weekend.

Thanks,
Serguei


On 2/20/14 1:05 AM, Siebenborn, Axel wrote:
> Yes, I need a sponsor for this change.
> Thanks for the reviews,
> Axel
>
>
>> -----Original Message-----
>> From: Volker Simonis [mailto:volker.simonis at gmail.com]
>> Sent: Donnerstag, 20. Februar 2014 09:21
>> To: serguei.spitsyn at oracle.com
>> Cc: Coleen Phillimore; hotspot-runtime-dev at openjdk.java.net;
>> serviceability-dev at openjdk.java.net; Siebenborn, Axel
>> Subject: Re: RFR(XS): JDK-8034867 - Object references from expression stack
>> are not visible as roots via jvmti FollowReferences and HeapDump
>>
>> Axel is covered by the SAP OCA.
>>
>> Thanks,
>> Volker
>>
>>
>> On Thu, Feb 20, 2014 at 6:30 AM, serguei.spitsyn at oracle.com
>> <serguei.spitsyn at oracle.com> wrote:
>>> It looks good to me too.
>>> But does Axel need to sign an OCA ?
>>>
>>> This is a link to follow:
>>>    http://openjdk.java.net/contribute/
>>>
>>>
>>> Thanks,
>>> Serguei
>>>
>>>
>>>
>>> On 2/19/14 11:28 AM, Coleen Phillimore wrote:
>>>
>>>
>>> This change looks good.  Do you need a sponsor?
>>> thanks,
>>> Coleen
>>>
>>> On 2/13/14 11:57 AM, Siebenborn, Axel wrote:
>>>
>>> Hi all,
>>>
>>> could I have a review for the following change?
>>>
>>>
>>>
>>> It adds code to iterate over the slots of the expression stack.
>>>
>>> Found object references are used as heap roots, the same way as object
>>> references in locals slots.
>>>
>>>
>>>
>>> Bug:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8034867
>>>
>>>
>>>
>>> Webrev:
>>>
>>> http://sapjvm.com/as/webrevs/8034867
>>>
>>>
>>>
>>> Thanks,
>>>
>>> Axel
>>>
>>>
>>>