Review Request: 8029921: CDS should allow user specify their own classlist

[Jiangli Zhou]

Hi David,

Thanks for the review. Will incorporate your suggestions.

Thanks,
Jiangli

On 01/06/2014 05:56 PM, David Holmes wrote:
> Hi Jiangli,
>
> On 7/01/2014 5:48 AM, Jiangli Zhou wrote:
>> Hi,
>>
>> Please review following change that allows alternative CDS classlist for
>> archiving by specifying -XX:ClassList=<path> from the command-line:
>>
>> webrev: http://cr.openjdk.java.net/~jiangli/8029921/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8029921
>
> I think ClassListFile would be a better name to make it clear it is in 
> fact a file name.
>
> In metaSpaceShared.cpp this comment block:
>
>  653   // Construct the path to the class list (in jre/lib)
>  654   // Walk up two directories from the location of the VM and
>  655   // optionally tack on "lib" (depending on platform)
>
> should moved into the if block after line #657.
>
> Thanks,
> David
>
>> Thanks,
>> Jiangli