RFR(XS): 8022301: [TESTBUG] runtime/jsig/Test8017498.sh incorrectly compiles native code

Calvin Cheung calvin.cheung at oracle.com
Thu Jan 9 10:47:35 PST 2014


Thanks for your review.
Calvin

On 1/9/2014 10:21 AM, Zhengyu Gu wrote:
> Good to me too.
>
> -Zhengyu
>
> On 1/8/2014 10:21 AM, Mikhailo Seledtsov wrote:
>> Looks good to me.
>>
>> Misha
>>
>> On 1/7/2014 8:49 PM, Calvin Cheung wrote:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8022301
>>>
>>> Problem:
>>>     When the test is run with 32-bit JDK, the script doesn't build 
>>> 32-bit native lib and resulting in failure.
>>>
>>> Fix:
>>>     Use the -m32 compile flag if a 32-bit JDK is being used.
>>>     Also adding the link option '-z noexecstack' as noted in the 
>>> description section.
>>>
>>> webrev:
>>>     http://cr.openjdk.java.net/~ccheung/8022301/webrev/
>>>
>>> Testing:
>>>     Ran the test case with 32- and 64-bit JDK on a linux-x64 machine.
>>>
>>> thanks,
>>> Calvin
>>
>



More information about the hotspot-runtime-dev mailing list