RFR: 7012961 runtime/jni/WindowsExceptionFilter/WindowsExceptionFilter01 crashes on windows-amd64

Zhengyu Gu zhengyu.gu at oracle.com
Thu Jan 9 10:57:39 PST 2014


Thanks for the review.

-Zhengyu

On 1/9/2014 1:45 PM, Calvin Cheung wrote:
> Looks good.
>
> One minor nit:
> 2245 PCONTEXT ctx = exceptionInfo->ContextRecord;
>
> the above line can be moved before line 2243 and line 2276 can be 
> deleted.
>
> Calvin
>
> On 12/11/2013 9:52 AM, Zhengyu Gu wrote:
>> This is another nightly clean up bug, and it is targeted to JDK9.
>>
>> The comment on original code line 2280 - 2281 is not accurate, since 
>> compiled code and intrinsic routines also can cause EXCEPTION_FLT_*. 
>> This particular testcase actually triggers 
>> EXCEPTION_FLT_DIVIDE_BY_ZERO from intrinsic routine.
>>
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-7012961
>> Webrev: http://cr.openjdk.java.net/~zgu/7012961/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Ezgu/7012961/webrev.00/>
>>
>> Test:
>>   Tested on Windows 64.
>>
>> Thanks,
>>
>> -Zhengyu
>



More information about the hotspot-runtime-dev mailing list