Review Request: 8029921: CDS should allow user specify their own classlist

[Bob Vandette]

On Jan 15, 2014, at 1:16 AM, David Holmes <David.Holmes at oracle.com> wrote:

> Hi Jiangli,
> 
> On 15/01/2014 3:19 AM, Jiangli Zhou wrote:
>> Hi David,
>> 
>> Thanks for the suggestion. How does it work with the existing
>> -Xshare:dump/auto/on option? Is it possible to combine multiple
>> sub-options, so it would be something like -Xshare:dump,classlist=XXXX?
> 
> Right - the classlist is only associated with dumping so some modification to -Xshare:dump would be the way to do it. Exactly how depends on what we think we may want to do in the future. For example do we want to allow control over the name of the archive? If so we might want something like:
> 
> -Xshare:dump:in=xxx,out=yyy
> 
> though I'm not sure of the best syntax/grammar to use for these kind of compound options.
> 
> At this stage we only want to define the class list file name so we don't need to generalize too far, but we also want to choose a syntax that doesn't preclude potential future changes.
> 
> Comments from runtime folk (Hi Coleen!) would be appreciated. :)

Do we want the ability to select different archives at startup that have been dumped with different class lists?

If so, then we'd need a way to specify the archive for -Xshare:on, ie -Xshare:on,archive=xxxx

-Xshare:dump,list=xxx,archive=yyy
-Xshare:on,archive=yyy

Otherwise if we don't want to support multiple archives, this option would be enough.

-Xshare:dump,list=xxx

Can we make the classlist easy to generate but either supporting  the -verbose:class output format or
by adding a new -verbose:classlist option, please?


Bob.


> 
> Thanks,
> David
> 
>> Thanks,
>> Jiangli
>> 
>> On 01/13/2014 06:29 PM, David Holmes wrote:
>>> On further thought I think this should be handled as part of the
>>> -Xshare option eg -Xshare:classlist=XXXX, as this is intended to be a
>>> supported feature of CDS.
>>> 
>>> That of course requires CCC approval processes to be followed.
>>> 
>>> David
>>> 
>>> On 8/01/2014 3:33 PM, David Holmes wrote:
>>>> On 8/01/2014 3:28 PM, David Holmes wrote:
>>>>> Looks fine - thanks.
>>>> 
>>>> Oops missed the follow-up. The further rename is fine too.
>>>> 
>>>> David
>>>> 
>>>>> David
>>>>> 
>>>>> On 8/01/2014 3:10 AM, Jiangli Zhou wrote:
>>>>>> Hi David,
>>>>>> 
>>>>>> Here is the updated webrev:
>>>>>> http://cr.openjdk.java.net/~jiangli/8029921/webrev.01/.
>>>>>> 
>>>>>> Thanks,
>>>>>> Jiangli
>>>>>> 
>>>>>> On 01/06/2014 05:59 PM, Jiangli Zhou wrote:
>>>>>>> Hi David,
>>>>>>> 
>>>>>>> Thanks for the review. Will incorporate your suggestions.
>>>>>>> 
>>>>>>> Thanks,
>>>>>>> Jiangli
>>>>>>> 
>>>>>>> On 01/06/2014 05:56 PM, David Holmes wrote:
>>>>>>>> Hi Jiangli,
>>>>>>>> 
>>>>>>>> On 7/01/2014 5:48 AM, Jiangli Zhou wrote:
>>>>>>>>> Hi,
>>>>>>>>> 
>>>>>>>>> Please review following change that allows alternative CDS
>>>>>>>>> classlist
>>>>>>>>> for
>>>>>>>>> archiving by specifying -XX:ClassList=<path> from the command-line:
>>>>>>>>> 
>>>>>>>>> webrev: http://cr.openjdk.java.net/~jiangli/8029921/webrev.00/
>>>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8029921
>>>>>>>> 
>>>>>>>> I think ClassListFile would be a better name to make it clear it is
>>>>>>>> in fact a file name.
>>>>>>>> 
>>>>>>>> In metaSpaceShared.cpp this comment block:
>>>>>>>> 
>>>>>>>> 653   // Construct the path to the class list (in jre/lib)
>>>>>>>> 654   // Walk up two directories from the location of the VM and
>>>>>>>> 655   // optionally tack on "lib" (depending on platform)
>>>>>>>> 
>>>>>>>> should moved into the if block after line #657.
>>>>>>>> 
>>>>>>>> Thanks,
>>>>>>>> David
>>>>>>>> 
>>>>>>>>> Thanks,
>>>>>>>>> Jiangli
>>>>>>> 
>>>>>> 
>>