RFR(S): JDK-8032250 : Add trace event for VM flag changes

Staffan Larsen staffan.larsen at oracle.com
Wed Jan 22 08:17:01 PST 2014


A couple of places in globals.cpp has changed from "<EventLongFlagChanged, s8>" to "<EventUnsignedLongFlagChanged, u8>".

(How I wish we had a review system where it was easy to see diffs between versions…)

/Staffan

On 22 jan 2014, at 16:53, Coleen Phillmore <coleen.phillimore at oracle.com> wrote:

> 
> Okay, so he's a better reviewer than I am.   What is the diff between the two versions?
> Thanks,
> Coleen
> 
> On 1/22/2014 10:28 AM, Erik Helin wrote:
>> Hi Staffan,
>> 
>> the change looks good now :)
>> 
>> Thanks,
>> Erik
>> 
>> On 2014-01-22 16:02, Staffan Larsen wrote:
>>> Erik discovered that I used traced events with signed values for some unsigned flag types.
>>> 
>>> So, new revision: http://cr.openjdk.java.net/~sla/8032250/webrev.02/
>>> 
>>> Thanks,
>>> /Staffan
>>> 
>>> On 22 jan 2014, at 15:08, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>>> 
>>>> Erik Helin suggested using template functions instead of macros which makes the code a little more type safe.
>>>> 
>>>> Also added a missing #include in globals.cpp.
>>>> 
>>>> Here is a new version of the webrev: http://cr.openjdk.java.net/~sla/8032250/webrev.01/
>>>> 
>>>> Thanks,
>>>> /Staffan
>>>> 
>>>> On 21 jan 2014, at 14:47, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>>>> 
>>>>> This is a patch to capture a trace event whenever a manageable VM flag is changed in runtime.
>>>>> 
>>>>> webrev: http://cr.openjdk.java.net/~sla/8032250/webrev.00/
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8032250
>>>>> 
>>>>> Thanks,
>>>>> /Staffan
>>>> 
>>> 
> 



More information about the hotspot-runtime-dev mailing list