RFR 8028275: Metaspace ShrinkGrowTest causes fatal error if run with JFR

[David Holmes]

On 25/01/2014 11:05 AM, Coleen Phillimore wrote:
>
> Thanks Harold!  Hoping the other reviewer will see this too (David?)

Yep - looks good to me (sorry was a holiday weekend here)

It is scary how much ancient crud we still carry around :(

Thanks,
david

> Coleen
>
> On 1/24/14 4:52 PM, harold seigel wrote:
>> Hi Coleen,
>>
>> That looks a lot cleaner.
>>
>> Thanks, Harold
>>
>> On 1/24/2014 2:53 PM, Coleen Phillimore wrote:
>>>
>>> In a separate email Harold pointed out that we'd investigated the
>>> early java.lang.Compiler initialization and found it wasn't needed
>>> because the ancient bug it was working around is fixed.   I verified
>>> this with the ancient test case as well.
>>>
>>> New webrev of additional code cleanup is here.  Retested against
>>> vm.quick.testlist.
>>>
>>> http://cr.openjdk.java.net/~coleenp/8028275_2/
>>>
>>> Thanks,
>>> Coleen
>>>
>>> On 1/23/14 1:43 PM, harold seigel wrote:
>>>> Hi Coleen,
>>>>
>>>> Your changes look good.
>>>>
>>>> Thanks, Harold
>>>>
>>>> On 1/16/2014 5:46 PM, Coleen Phillimore wrote:
>>>>> Summary: Clean up initialization from Threads::create_vm() so that
>>>>> exceptions cause vm_exit_during_initialization without an exception
>>>>> mark.
>>>>>
>>>>> My attempt at cleaning up initialization code paths that can throw
>>>>> an exception.  I only cleaned up the code in Threads::create_vm().
>>>>> There are other places where EXCEPTION_MARK can occur after
>>>>> Universe::is_fully_initialized() and before
>>>>> is_initialization_complete() deeply embedded in the code. But I did
>>>>> some refactoring.
>>>>>
>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8028275/
>>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8028275
>>>>>
>>>>> Tested with nsk.quick.testlist and with the hotspot jtreg tests,
>>>>> and some custom code to test exception paths.
>>>>>
>>>>> Thanks,
>>>>> Coleen
>>>>>
>>>>
>>>
>>
>