JDK-8027113 fix for jdk 9 code review updated

[David Holmes]

Hi Ron,

On 28/01/2014 2:18 PM, Ron Durbin wrote:
>
> JDK-8027113 decouples the '-XXaltjvm=<path>' option from the gamma launcher

This had me somewhat confused as I (not unreasonably) assumed that the 
-XXaltjvm option was processed by the VM. I didn't realize it was 
processed by the launcher (makes sense as it is telling the launcher 
which libjvm to load)! That said I'm unclear why the launcher doesn't 
then tell the VM that -XXaltjvm was used (by setting the property) 
rather than the user having to specify both -XXaltjvm and 
-Dsun.java.launcher.is_altjvm=true on the command-line? What happens if 
the user lies and sets -Dsun.java.launcher.is_altjvm=false, or doesn't 
set it at all; or sets it but not -XXaltjvm ? This seems error prone.

Aside: Arguments::process_java_launcher_argument seems somewhat 
unnecessary now all it does is a strdup.

Thanks,
David

> Web URL http://cr.openjdk.java.net/~rdurbin/JDK-8027113-cr1-webrev
>
> Internal URL: http://javaweb.us.oracle.com/~rdurbin/JDK-8027113-cr1-webrev
>
> Summary:
> Refactor the code so that it is no longer tightly coupled with the "gamma launcher". This will allow work on the following bug to proceed:
>
>      JDK-8005262 possible gamma launcher issues
>
> Testing included:
>     JPRT run
>     Manual launcher tests on:
> 	Win7-64 Cygwin,
> 	Win7-64 VS2010.
> 	Solaris 64 bit
>       Linux 64 bit
>