RFR(M): 8032462 Change the linux SDT implementation to use USDT2 instead of USDT1

[Staffan Larsen]

No, there is no plan to support systemtap or dtrace in the Oracle JDK right now. I just want to make sure my change isn’t breaking things for people downstream (the IcedTea project in particular).

/Staffan


On 28 jan 2014, at 20:29, Leonid Mesnik <leonid.mesnik at oracle.com> wrote:

> removed cc
> 
> Are we going to support dtrace on linux? Should we test any dtrace functionality on linux?
> 
> 
> Leonid
> 
> On 01/28/2014 11:02 PM, Staffan Larsen wrote:
>> 
>> On 28 jan 2014, at 15:51, Keith McGuigan <kmcguigan at twitter.com> wrote:
>> 
>>> Hi Staffan,
>>> 
>>> It looks ok to me.
>> 
>> Thanks Keith!
>> 
>>>  LInux has a 'dtrace' command now?
>> 
>> Yeah, it’s only there to provide the most basic dtrace compatibility for systemtap. I don’t think it can run dtrace scripts, but it can generate the header files we need.
>> 
>> /Staffan
>> 
>>> 
>>> --
>>> - Keith
>>> 
>>> 
>>> On Tue, Jan 28, 2014 at 3:52 AM, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>>> Still looking for reviewers for this change.
>>> 
>>> Thanks,
>>> /Staffan
>>> 
>>> On 23 jan 2014, at 08:36, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>>> 
>>> > The only usage today of the DTrace macros under the USDT1 define is the SDT provider on linux. This can be changed to use the USDT2 style by preprocessing the .d files into .h files with the dtrace utility in the same way as we do on solaris and OS X.
>>> >
>>> > I have also moved the provider definition files (hotspot.d, hotspot_jni.d and hs_private.d) to a common directory instead of having one identical copy per platform.
>>> >
>>> > I would really like to have a review from somebody on the IcedTea team since I haven’t been able to fully verify this change by running systemtap.
>>> >
>>> > Once this change is done, we can proceed to remove the USDT1 style macros.
>>> >
>>> > webrev: http://cr.openjdk.java.net/~sla/8032462/webrev.00/
>>> > bug: https://bugs.openjdk.java.net/browse/JDK-8032462
>>> >
>>> > testing: vm.dtrace.testlist in nsk
>>> >
>>> > Thanks,
>>> > /Staffan
>>> 
>>> 
>> 
> 
> 
> -- 
> Leonid Mesnik
> JVM SQE

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20140128/30f13463/attachment.html