RFR(M): 8032462 Change the linux SDT implementation to use USDT2 instead of USDT1

[Coleen Phillimore]

Ok, good!
Coleen

On 1/29/14 3:17 AM, Staffan Larsen wrote:
> Thanks Coleen!
>
> I am planning to remove all the "#ifndef USDT2” stuff in an upcoming 
> change.
>
> /Staffan
>
> On 28 jan 2014, at 22:34, Coleen Phillimore 
> <coleen.phillimore at oracle.com <mailto:coleen.phillimore at oracle.com>> 
> wrote:
>
>>
>> This looks like a good improvement.  I was hoping when I clicked on 
>> this that since USDT1 can be discontinued, you could remove the code 
>> under the ifndef USDT2 macros, ie:
>>    62 #ifndef USDT2
>>    63
>>    64 #define DTRACE_PROBE(a,b) {;}
>>    65 #define DTRACE_PROBE1(a,b,c) {;}
>>    66 #define DTRACE_PROBE2(a,b,c,d) {;}
>>    67 #define DTRACE_PROBE3(a,b,c,d,e) {;}
>>
>> Or is this in an upcoming change, or can you not do this yet?
>> Thanks,
>> Coleen
>> On 1/28/14 3:52 AM, Staffan Larsen wrote:
>>> Still looking for reviewers for this change.
>>>
>>> Thanks,
>>> /Staffan
>>>
>>> On 23 jan 2014, at 08:36, Staffan Larsen<staffan.larsen at oracle.com>  wrote:
>>>
>>>> The only usage today of the DTrace macros under the USDT1 define is the SDT provider on linux. This can be changed to use the USDT2 style by preprocessing the .d files into .h files with the dtrace utility in the same way as we do on solaris and OS X.
>>>>
>>>> I have also moved the provider definition files (hotspot.d, hotspot_jni.d and hs_private.d) to a common directory instead of having one identical copy per platform.
>>>>
>>>> I would really like to have a review from somebody on the IcedTea team since I haven’t been able to fully verify this change by running systemtap.
>>>>
>>>> Once this change is done, we can proceed to remove the USDT1 style macros.
>>>>
>>>> webrev:http://cr.openjdk.java.net/~sla/8032462/webrev.00/
>>>> bug:https://bugs.openjdk.java.net/browse/JDK-8032462
>>>>
>>>> testing: vm.dtrace.testlist in nsk
>>>>
>>>> Thanks,
>>>> /Staffan
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20140129/470e021c/attachment.html