RFR (XXS): JDK-8046668 : Excessive checked JNI warnings from Java startup

[harold seigel]

Hi David,

It looks good.  FWIW: the two += statements could be combined into one.

  210 static inline void
  211 checked_jni_add_planned_handle_capacity(JNIHandleBlock* handles, size_t capacity) {
  212   capacity += handles->get_number_of_live_handles();
  213   capacity += CHECK_JNI_LOCAL_REF_CAP_WARN_THRESHOLD;
  214   handles->set_planned_capacity(capacity);
  215 }

Harold


On 6/17/2014 4:26 AM, David Simms wrote:
> Hello,
>
> I have fix for the following bug:
>
>     JDK-8046668 : "Excessive checked JNI warnings from Java startup"
>
>     https://bugs.openjdk.java.net/browse/JDK-8046668
>
> Web review:
>
>     http://cr.openjdk.java.net/~dsimms/8046668/
>
> This fix remove some of the pedantic JNI exception checks warnings for 
> functions that throw ArrayOutOfBoundException. It was found almost all 
> code checks array length, making exception checking code meaningless 
> for these function.
>
> Also fix a small bug for the excessive local reference warnings 
> (always add to current number of live handles).
>
> Testing:
>
>     All platforms:
>     - JPRT
>     - VM testbase: " vm.quick.testlist 
> vm.parallel_class_loading.testlist vm.regression.testlist 
> vm.runtime.testlist"
>     - JTREG: JDK & JVM
>
>
>