RFR (S/M) expose L1_data_cache_line_size for diagnostic/sanity checks (8049717)

[Daniel D. Daugherty]

On 7/11/14 10:09 AM, Daniel D. Daugherty wrote:
> Vladimir, thanks for the thorough review.
>
>
> On 7/10/14 1:07 PM, Vladimir Kozlov wrote:
>> Hi Dan
>> objectMonitor.cpp and synchronizer.cpp:
>>
>> cast to 'int' but destination is 'unsigned' (also you can use 'uint'):
>>
>> unsigned int offset_stwRandom = (int)
>
> I'll check that out.

I went with the shorter 'uint'. Thanks!


>
>
>> combine two 'if (verbose)' into one.
>
> I'll check that out also.

I don't see two adjacent 'if (verbose)' lines. If you mean this style:

2543   unsigned int offset_header = (int)(addr_header - addr_begin);
2544   if (verbose) tty->print_cr("INFO: offset(_header)=%d", 
offset_header);
2545
2546   unsigned int offset_owner = (int)(addr_owner - addr_begin);
2547   if (verbose) tty->print_cr("INFO: offset(_owner)=%d", offset_owner);

I prefer to keep the verbose print_cr() line closer to the variable.

Dan




>
> Dan
>
>
>>
>> On 7/9/14 9:42 AM, Daniel D. Daugherty wrote:
>>> Greetings,
>>>
>>> I have the fix for the following bug ready for JDK9 RT_Baseline:
>>>
>>>      JDK-8049717 expose L1_data_cache_line_size for diagnostic/sanity
>>>                  checks
>>>      https://bugs.openjdk.java.net/browse/JDK-8049717
>>>
>>> Here is the URL for the webrev:
>>>
>>> http://cr.openjdk.java.net/~dcubed/8049717-webrev/0-jdk9-hs-rt/
>>>
>>> This fix is a standalone piece from my Contended Locking reorder
>>> and cache-line bucket. I've split it off as an independent bug fix
>>> in order to make the reorder and cache-line bucket more clear.
>>>
>>> Testing:
>>>
>>> - JPRT test jobs
>>> - manual testing of the new output via existing options:
>>>    -XX:+UnlockExperimentalVMOptions -XX:SyncKnobs=Verbose=1
>>>    -XX:+ExecuteInternalVMTests -XX:+VerboseInternalVMTests
>>> - Aurora Adhoc nsk.sajdi and vm.parallel_class_loading as part of
>>>    testing for my Contended Locking reorder and cache-line bucket
>>>
>>> Thanks, in advance, for any comments, questions or suggestions.
>>>
>>> Dan
>>>
>>>
>