RFR (S/M) expose L1_data_cache_line_size for diagnostic/sanity checks (8049717)

[David Simms]

Looks good Dan, thanks for updating the comments, most helpful !

On 2014-07-15 04:41, Daniel D. Daugherty wrote:
> Thanks David!
>
> Dan
>
>
> On 7/14/14 7:50 PM, David Holmes wrote:
>> Thanks Dan! The updates look good to me.
>>
>> David
>>
>> On 15/07/2014 10:24 AM, Daniel D. Daugherty wrote:
>>> Greetings,
>>>
>>> I've tweaked the fix based on Vladimir's and David H's feedback.
>>> Hopefully, this is the last round...
>>>
>>> David H was kind enough to point out where I was misunderstanding
>>> the guidance in:
>>>
>>> http://wiki.openjdk.java.net/display/HotSpot/StyleGuide
>>>
>>> In particular, this bullet:
>>>
>>> * Use good taste to break lines and align corresponding tokens on
>>> adjacent lines.
>>>
>>> Here is the URL for the fourth round webrev:
>>>
>>> http://cr.openjdk.java.net/~dcubed/8049717-webrev/3-jdk9-hs-rt/
>>>
>>> The following files changed between round 2 and round 3:
>>>
>>> src/share/vm/runtime/objectMonitor.cpp
>>> src/share/vm/runtime/synchronizer.cpp
>>> src/share/vm/runtime/synchronizer.hpp
>>>
>>> Thanks, in advance, for any comments, questions or suggestions.
>>>
>>> Dan
>>>
>>>
>>>
>>> On 7/14/14 11:47 AM, Daniel D. Daugherty wrote:
>>>> Greetings,
>>>>
>>>> I've tweaked the fix based on David H's feedback.
>>>>
>>>> Here is the URL for the third round webrev:
>>>>
>>>> http://cr.openjdk.java.net/~dcubed/8049717-webrev/2-jdk9-hs-rt/
>>>>
>>>> The following files changed between round 1 and round 2:
>>>>
>>>> src/share/vm/runtime/objectMonitor.cpp
>>>> src/share/vm/runtime/synchronizer.cpp
>>>>
>>>> Thanks, in advance, for any comments, questions or suggestions.
>>>>
>>>> Dan
>>>>
>>>>
>>>> On 7/11/14 2:14 PM, Daniel D. Daugherty wrote:
>>>>> Greetings,
>>>>>
>>>>> I've tweaked the fix based on Vladimir's feedback.
>>>>>
>>>>> Here is the URL for the second round webrev:
>>>>>
>>>>> http://cr.openjdk.java.net/~dcubed/8049717-webrev/1-jdk9-hs-rt/
>>>>>
>>>>> The following files changed between round 0 and round 1:
>>>>>
>>>>> src/cpu/sparc/vm/vm_version_sparc.cpp
>>>>> src/cpu/x86/vm/vm_version_x86.cpp
>>>>> src/cpu/x86/vm/vm_version_x86.hpp
>>>>> src/share/vm/runtime/objectMonitor.cpp
>>>>> src/share/vm/runtime/synchronizer.cpp
>>>>>
>>>>> Thanks, in advance, for any comments, questions or suggestions.
>>>>>
>>>>> Dan
>>>>>
>>>>>
>>>>> On 7/9/14 10:42 AM, Daniel D. Daugherty wrote:
>>>>>> Greetings,
>>>>>>
>>>>>> I have the fix for the following bug ready for JDK9 RT_Baseline:
>>>>>>
>>>>>>     JDK-8049717 expose L1_data_cache_line_size for diagnostic/sanity
>>>>>>                 checks
>>>>>>     https://bugs.openjdk.java.net/browse/JDK-8049717
>>>>>>
>>>>>> Here is the URL for the webrev:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~dcubed/8049717-webrev/0-jdk9-hs-rt/
>>>>>>
>>>>>> This fix is a standalone piece from my Contended Locking reorder
>>>>>> and cache-line bucket. I've split it off as an independent bug fix
>>>>>> in order to make the reorder and cache-line bucket more clear.
>>>>>>
>>>>>> Testing:
>>>>>>
>>>>>> - JPRT test jobs
>>>>>> - manual testing of the new output via existing options:
>>>>>>   -XX:+UnlockExperimentalVMOptions -XX:SyncKnobs=Verbose=1
>>>>>>   -XX:+ExecuteInternalVMTests -XX:+VerboseInternalVMTests
>>>>>> - Aurora Adhoc nsk.sajdi and vm.parallel_class_loading as part of
>>>>>>   testing for my Contended Locking reorder and cache-line bucket
>>>>>>
>>>>>> Thanks, in advance, for any comments, questions or suggestions.
>>>>>>
>>>>>> Dan
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>