RFR(S): JDK-8044364: runtime/RedefineFinalizer test fails on windows

Dmitry Samersoff dmitry.samersoff at oracle.com
Sun Jun 1 20:59:48 UTC 2014


Christian,

I'm fine with either version of this test so you can take ownership of
this CR.

1. My jtreg can't find RedefineClassHelper.java in /testlibrary so I had
to copy it to test/runtime/RedefineFinalizer first.

2. It's better to use sun.tools.jar then launch a separate process.

-Dmitry

On 2014-06-01 20:34, Christian Tornqvist wrote:
> Hi Dmitry,
> 
> I've got an alternative change for fixing the test, based on some redefine class test code I wrote last year (but never pushed). 
> 
> See the webrev at:
> http://cr.openjdk.java.net/~ctornqvi/webrev/redef_fin/webrev/
> 
> This adds a general library to easily support writing tests that is using redefine classes along with a POC test for testing the RedefineClassHelper.
> 
> Please let me know what you think.
> 
> Thanks,
> Christian
> 
> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Dmitry Samersoff
> Sent: Friday, May 30, 2014 3:59 PM
> To: hotspot-runtime-dev
> Subject: RFR(S): JDK-8044364: runtime/RedefineFinalizer test fails on windows
> 
> Hi Everyone,
> 
> http://cr.openjdk.java.net/~dsamersoff/JDK-8044364/webrev.01/
> 
> I rewrote test launcher in java.
> 
> Compilation left up to JTREG. So the test compiles with tools.jar from COMPILEJAVA but run with tools.jar from TESTJAVA - the same way as all other similar tests.
> 
> -Dmitry
> 
> --
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the hotspot-runtime-dev mailing list