code review round 0 DK-8038132 jprt bundles have libjsig.dylib in different place on OSX

Daniel D. Daugherty daniel.daugherty at oracle.com
Mon Jun 2 20:11:02 UTC 2014


Thanks for the sanity check!

And I missed the step where I usually update the copyright. Sigh.
Not worth fixing the copyright in the JDK9 version since there will
likely be another related fix coming for the FDS strangeness that
Ron ran into while hunting down this piece.

I will fix the copyright in the JDK8u-hs version.

Dan


On 6/2/14 2:07 PM, Lois Foltan wrote:
> Looks good, the copyright notice should have been updated in the JDK 9 
> change.  I don't know if you want to update it now for JDK 8u.
> Lois
>
> On 6/2/2014 3:50 PM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> Need a sanity check review for the JDK8u-hs backport of Ron's fix:
>>
>> Webrev URL: http://cr.openjdk.java.net/~dcubed/8038132-webrev/0-jdk8u-hs
>>
>> Dan
>>
>>
>> On 5/31/14 7:24 PM, Ron Durbin wrote:
>>> Greetings,
>>>
>>> This fix resolves:
>>> JDK-8038132  jprt bundles have libjsig.dylib in different place on OSX
>>>
>>> Summary:
>>> The build of Hotspot should not remove the symlinks for libjsig.
>>>
>>> You will find the webrev by following the URL below.
>>>
>>> http://cr.openjdk.java.net/~rdurbin/JDK-8038132-webrev-cr0
>>>
>>>
>>
>



More information about the hotspot-runtime-dev mailing list