RFR(M) JDK-8031819: Remove legacy jdk checks and code

harold seigel harold.seigel at oracle.com
Wed Jun 4 17:05:35 UTC 2014


Hi Lois,

Thanks for the review.  I removed the comment.

Harold

On 6/4/2014 11:51 AM, Lois Foltan wrote:
> Great clean up!  Looks good.  Only a tiny minor comment. In 
> reflectionUtils.cpp, I would also remove the comment "The following 
> class fields do not exist in previous version of jdk". I find that 
> more confusing than helpful.  I don't need to see a new webrev though.
>
> Lois
>
>
> On 6/4/2014 11:34 AM, harold seigel wrote:
>> Hi,
>>
>> Please review this JDK 9 fix for bug JDK-8031819.  The fix removes 
>> legacy code for old JDK versions.  Although the webrev contains lots 
>> of files, the changes are not complicated.
>>
>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8031819/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8031819
>>
>> The fix was tested with the Hotspot JTREG tests, JCK Lang, VM, and 
>> API/java_lang tests, nsk Quick tests, and JPRT.
>>
>> Thanks! Harold
>



More information about the hotspot-runtime-dev mailing list