RFR(M) JDK-8031819: Remove legacy jdk checks and code

harold seigel harold.seigel at oracle.com
Wed Jun 4 18:39:47 UTC 2014


Coleen, Zhengyu:

Thanks for the reviews.

I plan to follow Coleen's advice and leave in the call to 
clear_stacktrace().

Thanks again,

Harold

On 6/4/2014 2:10 PM, Coleen Phillimore wrote:
>
> Harold,  I reviewed this and it looks good.   One comment.
> On 6/4/14, 12:59 PM, Zhengyu Gu wrote:
>> Thanks for cleaning up.
>>
>> javaClasses.cpp:
>>
>> 1545   // This is unnecessary in 1.7+ but harmless
>> 1546   clear_stacktrace(throwable());
>>
>> I think they can go also.
>
> Can you leave this in because it seems like a good idea and hygenic 
> and something might break if you take it out?
>
> Coleen
>
>>
>> -Zhengyu
>>
>>
>>
>> On 6/4/2014 11:34 AM, harold seigel wrote:
>>> Hi,
>>>
>>> Please review this JDK 9 fix for bug JDK-8031819.  The fix removes 
>>> legacy code for old JDK versions.  Although the webrev contains lots 
>>> of files, the changes are not complicated.
>>>
>>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8031819/
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8031819
>>>
>>> The fix was tested with the Hotspot JTREG tests, JCK Lang, VM, and 
>>> API/java_lang tests, nsk Quick tests, and JPRT.
>>>
>>> Thanks! Harold
>>
>



More information about the hotspot-runtime-dev mailing list