RFR(M) JDK-8031819: Remove legacy jdk checks and code

[harold seigel]

Hi Christian,

How about if I change the comment to:

       // FIXIT: The check for null is legacy code.  This has to be
    fixed by a
       // runtime query method

(Not sure what is meant by "runtime query method".)

Perhaps the comment should just be removed?

Thanks, Harold

On 6/4/2014 4:40 PM, Christian Thalinger wrote:
> *src/share/vm/runtime/thread.cpp:*
> *     // FIXIT: The is_null check is only so it works better on JDK1.2 VM's. This*
> *     // has to be fixed by a runtime query method*
> *-    if (!destroy_vm  || JDK_Version::is_jdk12x_version()) {*
> Maybe change the comment.
>
> On Jun 4, 2014, at 8:34 AM, harold seigel <harold.seigel at oracle.com 
> <mailto:harold.seigel at oracle.com>> wrote:
>
>> Hi,
>>
>> Please review this JDK 9 fix for bug JDK-8031819.  The fix removes 
>> legacy code for old JDK versions.  Although the webrev contains lots 
>> of files, the changes are not complicated.
>>
>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8031819/ 
>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8031819/>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8031819
>>
>> The fix was tested with the Hotspot JTREG tests, JCK Lang, VM, and 
>> API/java_lang tests, nsk Quick tests, and JPRT.
>>
>> Thanks! Harold
>