RFR(M) JDK-8031819: Remove legacy jdk checks and code

[harold seigel]

Dan,  thanks for checking!

I think I'll delete the comment, since it no longer has any meaning to 
anyone.

Harold

On 6/5/2014 1:57 PM, Daniel D. Daugherty wrote:
> On 6/5/14 10:55 AM, Christian Thalinger wrote:
>> On Jun 5, 2014, at 8:59 AM, harold seigel <harold.seigel at oracle.com> 
>> wrote:
>>
>>> Hi Christian,
>>>
>>> How about if I change the comment to:
>>>
>>>       // FIXIT: The check for null is legacy code.  This has to be
>>>    fixed by a
>>>       // runtime query method
>>>
>>> (Not sure what is meant by "runtime query method".)
>>>
>>> Perhaps the comment should just be removed?
>> Yeah, I was wondering myself.  Any clues looking at Mercurial 
>> history?  Probably not.
>
> And you would be right about Mercurial:
>
> $ hg annot src/share/vm/runtime/thread.cpp | grep 'FIXIT: The is_null 
> check'
>    0:   // FIXIT: The is_null check is only so it works better on 
> JDK1.2 VM's. This
>
> Unfortunately, TeamWare is not much more help:
>
> $ sgv -r1.478.7.4 src/share/vm/runtime/thread.cpp | grep 'FIXIT: The 
> is_null check'
> 1.478.7.4
> 1.478.7.3         // FIXIT: The is_null check is only so it works 
> better on JDK1.2 VM's. This
>
> $ sp -r1.478.7.3 src/share/vm/runtime/thread.cpp
> src/share/vm/runtime/SCCS/s.thread.cpp:
>
> D 1.478.7.3 99/05/20 14:51:05 renes 1196 1195   00066/00040/01854
> MRs:
> COMMENTS:
>
> So this change dates back to when HotSpot did not require bug numbers...
>
>
> Dan
>
>
>>
>>> Thanks, Harold
>>>
>>> On 6/4/2014 4:40 PM, Christian Thalinger wrote:
>>>> *src/share/vm/runtime/thread.cpp:*
>>>> *     // FIXIT: The is_null check is only so it works better on 
>>>> JDK1.2 VM's. This*
>>>> *     // has to be fixed by a runtime query method*
>>>> *-    if (!destroy_vm  || JDK_Version::is_jdk12x_version()) {*
>>>> Maybe change the comment.
>>>>
>>>> On Jun 4, 2014, at 8:34 AM, harold seigel <harold.seigel at oracle.com 
>>>> <mailto:harold.seigel at oracle.com>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Please review this JDK 9 fix for bug JDK-8031819.  The fix removes 
>>>>> legacy code for old JDK versions.  Although the webrev contains 
>>>>> lots of files, the changes are not complicated.
>>>>>
>>>>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8031819/ 
>>>>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8031819/>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8031819
>>>>>
>>>>> The fix was tested with the Hotspot JTREG tests, JCK Lang, VM, and 
>>>>> API/java_lang tests, nsk Quick tests, and JPRT.
>>>>>
>>>>> Thanks! Harold
>