[9] RFR (XXS): 8046226: assert(_thread == Thread::current()) failed: thread must be current w/ -XX:+TraceDeoptimization -XX:+Verbose

[Christian Thalinger]

On Jun 6, 2014, at 7:57 AM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:

> On 6/6/14 8:08 AM, Vladimir Ivanov wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8046226
>> http://cr.openjdk.java.net/~vlivanov/8046226/webrev.00/
> 
> src/share/vm/runtime/vframe.cpp
>    I think it's worth a short comment to keep someone from
>    "optimizing" this in the future:

Good point.  Might be worth to pass in Thread::current() to make it explicit plus the comment.

> 
>                  // need the current JavaThread and not thread():
>    line 272:     methodHandle m_h(method());
> 
>    And if you could add the same comment above:
> 
>                    // need the current JavaThread and not thread():
>    line 333:       methodHandle m_h(method());
> 
> Dan
> 
>> 
>> Method handle should be associated with current thread and not with a thread which owns vframe.
>> 
>> Testing: manual (attached Java debugger to debug JVM w/ -XX:+TraceDeoptimization -XX:+Verbose and inspected local variables).
>> 
>> Thanks!
>> 
>> Best regards,
>> Vladimir Ivanov
>