[9] RFR (XXS): 8046226: assert(_thread == Thread::current()) failed: thread must be current w/ -XX:+TraceDeoptimization -XX:+Verbose

[Christian Thalinger]

Looks good.

On Jun 6, 2014, at 3:21 PM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:

> Dan, Chris, Fred, thank you!
> 
>>> src/share/vm/runtime/vframe.cpp
>>>    I think it's worth a short comment to keep someone from
>>>    "optimizing" this in the future:
>> 
>> Good point.  Might be worth to pass in Thread::current() to make it explicit plus the comment.
> Yes, I agree. Updated webrev:
> http://cr.openjdk.java.net/~vlivanov/8046226/webrev.01/
> 
> Best regards,
> Vladimir Ivanov
> 
>>> 
>>>                  // need the current JavaThread and not thread():
>>>    line 272:     methodHandle m_h(method());
>>> 
>>>    And if you could add the same comment above:
>>> 
>>>                    // need the current JavaThread and not thread():
>>>    line 333:       methodHandle m_h(method());
>>> 
>>> Dan
>>> 
>>>> 
>>>> Method handle should be associated with current thread and not with a thread which owns vframe.
>>>> 
>>>> Testing: manual (attached Java debugger to debug JVM w/ -XX:+TraceDeoptimization -XX:+Verbose and inspected local variables).
>>>> 
>>>> Thanks!
>>>> 
>>>> Best regards,
>>>> Vladimir Ivanov
>>> 
>>