RFR (L/XXS) cleanup non-indent white space issues (8046758)

Daniel D. Daugherty daniel.daugherty at oracle.com
Mon Jun 16 17:45:03 UTC 2014


Greetings,

I have the fix for the following bug ready for JDK9 RT_Baseline:

     JDK-8046758 cleanup non-indent white space issues prior to Contended
                 Locking cleanup bucket
     https://bugs.openjdk.java.net/browse/JDK-8046758

This is both a (L)arge and e(X)tra e(X)tra (S)mall review! Here is the
URL for the (L)arge webrev:

http://cr.openjdk.java.net/~dcubed/8046758-webrev/0-jdk9-hs-rt/

Since these are white space fixes, I recommend the udiff links instead
of the frames links. Of course, some folks prefer the patch file itself
for white space fixes.

Here is the URL for the e(X)tra e(X)tra (S)mall webrev which was generated
with a version of webrev that ignores all whitespace changes:

http://cr.openjdk.java.net/~dcubed/8046758-webrev/0-jdk9-hs-rt-no_ws/

Again, I recommend the udiff links since that's the fastest way to see
that webrev_no_ws found no non-white space changes. The patch file for
this webrev shows all the white space changes.

These non-indent white space cleanups were done in preparation for the
cleanup bucket from the Contended Locking project; these changes were made
by my do_space_filter.ksh script. The script does not fix everything in
these files that is not in sync with HotSpot style, but it does fix a
large portion of them. In particular, the do_space_filter.ksh script does
_not_ fix incorrect indenting; I'm mulling on a different solution for
that problem.

Thanks, in advance, for any comments, questions or suggestions.

At the end of the review cycle for this fix, I will attach the version of
the do_space_filter.ksh script used to do the work to JDK-8046758.

Dan


More information about the hotspot-runtime-dev mailing list