RFR (M/XXS) cleanup more non-indent white space issues (8047156)
Coleen Phillimore
coleen.phillimore at oracle.com
Wed Jun 18 17:45:13 UTC 2014
This looks good. Looks like the copy of PlatformEvent in os_aix.hpp
didn't copy the wrong whitespace changes.
Thanks,
Coleen
On 6/18/14, 12:26 AM, Daniel D. Daugherty wrote:
> Thanks for the fast review!
>
> Dan
>
>
> On 6/17/14 8:12 PM, serguei.spitsyn at oracle.com wrote:
>> Looks good.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 6/17/14 6:12 PM, Daniel D. Daugherty wrote:
>>> Greetings,
>>>
>>> I forgot to update my list of files to clean for the latest version
>>> of the cleanup bucket so I missed these seven files when I sent out
>>> the review for:
>>>
>>> JDK-8046758 cleanup non-indent white space issues prior to
>>> Contended
>>> Locking cleanup bucket
>>> https://bugs.openjdk.java.net/browse/JDK-8046758
>>>
>>> I have the fix for the following bug ready for JDK9 RT_Baseline:
>>>
>>> JDK-8047156 cleanup more non-indent white space issues prior to
>>> Contended Locking cleanup bucket
>>> https://bugs.openjdk.java.net/browse/JDK-8047156
>>>
>>> This is both a (M)edium and e(X)tra e(X)tra (S)mall review! Here is the
>>> URL for the (M)edium webrev:
>>>
>>> http://cr.openjdk.java.net/~dcubed/8047156-webrev/0-jdk9-hs-rt/
>>>
>>> Since these are white space fixes, I recommend the udiff links instead
>>> of the frames links. Of course, some folks prefer the patch file itself
>>> for white space fixes.
>>>
>>> Here is the URL for the e(X)tra e(X)tra (S)mall webrev which was
>>> generated with a version of webrev that ignores all whitespace changes:
>>>
>>> http://cr.openjdk.java.net/~dcubed/8047156-webrev/0-jdk9-hs-rt-no_ws/
>>>
>>> Again, I recommend the udiff links since that's the fastest way to see
>>> that webrev_no_ws found no non-white space changes. The patch file for
>>> this webrev shows all the white space changes.
>>>
>>> Thanks, in advance, for any comments, questions or suggestions.
>>>
>>> At the end of the review cycle for this fix, I will attach the
>>> version of the do_space_filter.ksh script used to do the work to
>>> JDK-8047156.
>>>
>>> Dan
>>>
>>>
>>
>
More information about the hotspot-runtime-dev
mailing list