Review request(7u): Backport of bugs 8031290 and 8019324

[David Holmes]

On 26/06/2014 3:06 PM, Poonam Bajaj wrote:
> Hi David,
>
> The changes are same but at places I had to manually add the changes
> because of the difference in the surrounding code. e.g.
> 'aes_instructions' is not defined in jdk7 so I had to manually add the
> definition of 'sparc5_instructions' in vm_version_sparc.hpp.

Thanks for clarifying - I misread part of the original 8031290 patch.

This looks like a valid backport of those two changes.

The backport request can be submitted as per:

http://openjdk.java.net/projects/jdk7u/approval-template.html

You might want to wait for Jon to also review it.

Thanks,
David

> Thanks,
> Poonam
>
> On 6/26/2014 8:15 AM, David Holmes wrote:
>> Hi Poonam,
>>
>> On 25/06/2014 11:11 PM, Poonam Bajaj wrote:
>>> Hi,
>>>
>>> Please review these changes that backport the fixes of 8031290 and
>>> 8019324 to 7u.
>>>
>>> Bugs:
>>> JDK-8031290: <https://bugs.openjdk.java.net/browse/JDK-8031290> Adjust
>>> call to getisax() for additional words returned
>>> JDK-8019324: <https://bugs.openjdk.java.net/browse/JDK-8019324>
>>> assert(_f2 == 0 || _f2 == f2) failed: illegal field change
>>>
>>> Webrev: http://cr.openjdk.java.net/~poonam/8031290_8019324/webrev.00/
>>>
>>> The first one is a direct backport and for the second fix methodOop had
>>> to be used in place of Method*.
>>
>> Your changes do not seem to be a direct backport of 8031290 in JDK 8:
>>
>> http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/031b06eac1a9
>>
>> Did you actually import the changeset or manually applied it?
>>
>> David
>> -----
>>
>>
>>> Thanks,
>>> Poonam