RFR (XS): 8033566: warning from b128 for hotspot/src/share/vm/runtime/frame.cpp: JNI primitive type mismatch

[Calvin Cheung]

Thanks! I'm all set and will push the fix.

Calvin

On 3/24/2014 9:59 AM, Coleen Phillimore wrote:
>
> Calvin,
> This looks good.
> Coleen
>
> On 3/20/14 4:49 PM, Calvin Cheung wrote:
>> Please review this small fix for fixing a warning from our internal code
>> analysis tool. The problem is that on 64-bit platforms, the uintptr_t is
>> 64-bit and we tried to return it as a jint which is always 32-bit.
>> A simple fix is to add an assert to make sure the value is <= max_jint
>> before returning it as a jint.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8033566
>>      (internal, below is the details)
>> Expecting value of JNI primitive type jint in return at line 536 of
>> jdk8-b128/src/hotspot/src/share/vm/runtime/frame.cpp in function
>> frame::interpreter_frame_expression_stack_size()
>>
>>
>> webrev: http://cr.openjdk.java.net/~ccheung/8033566/webrev/
>>
>> Tests:
>>    jprt
>>    jtreg hotspot tests
>>
>> thanks,
>> Calvin
>