RFR: 8031126 java/lang/management/ThreadMXBean/ThreadUserTime.java fails intermittently

Coleen Phillimore coleen.phillimore at oracle.com
Mon May 5 17:37:07 UTC 2014

This looks good.

On 5/5/14, 10:19 AM, Staffan Larsen wrote:
> Still looking for an official Review of this fix.
> Thanks,
> /Staffan
> On 29 apr 2014, at 16:21, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>> When JDK-8036122 "Fix warning "format not a string literal”” was fixed, the fix introduced a regression in
>> os_linux.cpp:slow_thread_cpu_time(). There is a static variable in the method with a format string. The format string was set to different value if NTPL was used. This check was only done once. After the fix, the incorrect format string is used on NPTL for all but the first call.
>> Since all our linux variants use NPTL now, I suggest a simple fix that has only one format string.
>> webrev: http://cr.openjdk.java.net/~sla/8031126/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8031126
>> Thanks,
>> /Staffan

More information about the hotspot-runtime-dev mailing list